Fixed bad free on stack.

Still need to figure that one out.

src/ast.c

@@ -123,7 +123,7 @@ void ast_exc_print(ASTExcData* data, int i) {
     INDENT_END;
 }
 
-ASTBIFData* ast_bif_data_init(AST* fn(size_t, AST**)) {
+ASTBIFData* ast_bif_data_init(AST* fn(size_t, AST**, Scope*)) {
     return (ASTBIFData*)fn;
 }
 

src/builtin.c

@@ -5,11 +5,11 @@
 #include <stdarg.h>
 #include <stdio.h>
 
-AST* builtin_sum(size_t argc, AST** argv) {
+AST* builtin_sum(size_t argc, AST** argv, Scope* parent) {
     ASTNumData total = 0;
 
     for (int i = 0; i < argc; i++) {
-        AST* arg = exec_exp(argv[i]);
+        AST* arg = exec_exp(argv[i], parent);
         if (arg->type == AST_TYPE_EXC)
             return ast_init(
                 AST_TYPE_EXC,
@@ -27,9 +27,9 @@ AST* builtin_sum(size_t argc, AST** argv) {
     return ast_init(AST_TYPE_NUM, ast_num_data_init(total));
 }
 
-AST* builtin_sub(size_t argc, AST** argv) {
+AST* builtin_sub(size_t argc, AST** argv, Scope* parent) {
     log_dbg("Got here");
-    AST* first = exec_exp(*argv);
+    AST* first = exec_exp(*argv, parent);
     if (first->type == AST_TYPE_EXC)
         return ast_init(
             AST_TYPE_EXC,
@@ -44,7 +44,7 @@ AST* builtin_sub(size_t argc, AST** argv) {
     ASTNumData total = *(ASTNumData*)first->data;
 
     for (int i = 1; i < argc; i++) {
-        AST* arg = exec_exp(argv[i]);
+        AST* arg = exec_exp(argv[i], parent);
         if (arg->type == AST_TYPE_EXC)
             return ast_init(
                 AST_TYPE_EXC,
@@ -62,9 +62,9 @@ AST* builtin_sub(size_t argc, AST** argv) {
     return ast_init(AST_TYPE_NUM, ast_num_data_init(total));
 }
 
-AST* builtin_mul(size_t argc, AST** argv) {
+AST* builtin_mul(size_t argc, AST** argv, Scope* parent) {
     log_dbg("Got here");
-    AST* first = exec_exp(*argv);
+    AST* first = exec_exp(*argv, parent);
     if (first->type == AST_TYPE_EXC)
         return ast_init(
             AST_TYPE_EXC,
@@ -79,7 +79,7 @@ AST* builtin_mul(size_t argc, AST** argv) {
     ASTNumData total = *(ASTNumData*)first->data;
 
     for (int i = 1; i < argc; i++) {
-        AST* arg = exec_exp(argv[i]);
+        AST* arg = exec_exp(argv[i], parent);
         if (arg->type == AST_TYPE_EXC)
             return ast_init(
                 AST_TYPE_EXC,
@@ -97,9 +97,9 @@ AST* builtin_mul(size_t argc, AST** argv) {
     return ast_init(AST_TYPE_NUM, ast_num_data_init(total));
 }
 
-AST* builtin_div(size_t argc, AST** argv) {
+AST* builtin_div(size_t argc, AST** argv, Scope* parent) {
     log_dbg("Got here");
-    AST* first = exec_exp(*argv);
+    AST* first = exec_exp(*argv, parent);
     if (first->type == AST_TYPE_EXC)
         return ast_init(
             AST_TYPE_EXC,
@@ -114,7 +114,7 @@ AST* builtin_div(size_t argc, AST** argv) {
     ASTNumData total = *(ASTNumData*)first->data;
 
     for (int i = 1; i < argc; i++) {
-        AST* arg = exec_exp(argv[i]);
+        AST* arg = exec_exp(argv[i], parent);
         if (arg->type == AST_TYPE_EXC)
             return ast_init(
                 AST_TYPE_EXC,

src/exec.c

@@ -12,15 +12,17 @@
 AST* exec_start(AST* ast) {
     log_dbg("Started execution.");
 
-    Scope* builtin = scope_init(NULL);
+    Scope* global = scope_init(NULL);
 
     for (int i = 0; i < BUILTIN_FNS_LN; i++)
         htab_ins(
-            builtin->here, BUILTIN_FNS[i].name,
+            global->here, BUILTIN_FNS[i].name,
             ast_init(AST_TYPE_BIF, ast_bif_data_init(BUILTIN_FNS[i].fn))
         );
 
-    return exec_exp(ast, builtin);
+    log_dbg("Completed startup sequence.");
+
+    return exec_exp(ast, global);
 }
 
 AST* exec_exp(AST* ast, Scope* parent) {
@@ -38,6 +40,7 @@ AST* exec_exp(AST* ast, Scope* parent) {
 AST* exec_block(AST* ast, Scope* parent) {
     ASTBlockData* block = (ASTBlockData*)ast->data;
 
+    // Blocks create their own scope, shared among their expressions.
     ast->scope = scope_init(parent);
 
     // Loop through all but last ast.
@@ -67,7 +70,7 @@ AST* exec_call(AST* ast, Scope* parent) {
     switch (fdef->type) {
         case AST_TYPE_BIF:
             ASTBIFData bifdata = fdef->data;
-            return bifdata(argc, argv);
+            return bifdata(argc, argv, parent);
         case AST_TYPE_FDEF: return exec_cf(fdef, argc, argv);
         default:
             return ast_init(AST_TYPE_EXC, ast_exc_data_init("Good job!", NULL));
@@ -87,15 +90,17 @@ AST* exec_cf(AST* ast, size_t argc, AST** argv) {
 }
 
 AST* exec_vdef(AST* ast, Scope* parent) {
-    ast->scope = scope_init(parent);
+    // Use parent's scope.
+    ast->scope = parent;
     ASTVDefData* data = (ASTVDefData*)ast->data;
     AST* val = data->val;
     char* key = data->name;
-    scope_add(parent, key, val);
+    scope_add(parent, key, val); // Add variable definition to parent scope.
-    return exec_exp(val, ast->scope);
+    return exec_exp(val, parent);
 }
 
 AST* exec_vref(AST* ast, Scope* parent) {
+    // Use parent's scope.
     ast->scope = parent;
     log_dbg("attempting to reference var");
     ASTVrefData* vref = (ASTVrefData*)ast->data;

src/htab.c

@@ -7,12 +7,13 @@
 #include <string.h>
 
 HTab* htab_init() {
-    HTab* htab = calloc(1, sizeof(HTab));
+    HTab* htab = malloc(sizeof(HTab));
 
     return htab;
 }
 
-void htab_destroy(HTab* htab) { free(htab); }
+void htab_destroy(HTab* htab) { // free(htab);
+}
 
 // Get the index of a key.
 size_t geti(char* key) {

src/include/ast.h

@@ -69,10 +69,10 @@ void ast_exc_data_destroy(ASTExcData* exc);
 void ast_exc_print(ASTExcData*, int i);
 
 // A built-in function.
-typedef AST* (*ASTBIFData)(size_t argc, AST** argv);
+typedef AST* (*ASTBIFData)(size_t argc, AST** argv, Scope* scope);
 
 // Create a built-in function.
-ASTBIFData* ast_bif_data_init(AST* fn(size_t, AST**));
+ASTBIFData* ast_bif_data_init(AST* fn(size_t, AST**, Scope*));
 
 // There is no `ASTBIFData` destroy function, as function pointers are immortal.
 

src/include/builtin.h

@@ -4,20 +4,20 @@
 #include "ast.h"
 
 // Sum some nums.
-AST* builtin_sum(size_t argc, AST** argv);
+AST* builtin_sum(size_t argc, AST** argv, Scope* parent);
 
 // Subtract nums.
-AST* builtin_sub(size_t argc, AST** argv);
+AST* builtin_sub(size_t argc, AST** argv, Scope* parent);
 
 // Multiply nums.
-AST* builtin_mul(size_t argc, AST** argv);
+AST* builtin_mul(size_t argc, AST** argv, Scope* parent);
 
 // Divide nums.
-AST* builtin_div(size_t argc, AST** argv);
+AST* builtin_div(size_t argc, AST** argv, Scope* parent);
 
 struct builtin_data {
     char* name;
-    AST* (*fn)(size_t argc, AST** argv);
+    AST* (*fn)(size_t argc, AST** argv, Scope* parent);
 };
 
 static struct builtin_data BUILTIN_FNS[] = {

src/include/scope.h

@@ -16,6 +16,6 @@ void scope_destroy(Scope* scope);
 // Destroy the current `Scope` only.
 void scope_destroy_psv(Scope *scope);
 // Insert a key/val pair into the `HTab` of a `Scope`.
-inline void scope_add(Scope* scope, char* key, void* val);
+void scope_add(Scope* scope, char* key, void* val);
 
 #endif

src/main.c

@@ -4,10 +4,8 @@
 #include "include/ast.h"
 #include "include/dstr.h"
 #include "include/exec.h"
-#include "include/global.h"
+
-#include "include/htab.h"
 #include "include/lexer.h"
-#include "include/stack.h"
 #include "include/util.h"
 
 #include "../build/grammars/grammar.tab.h"
@@ -17,16 +15,11 @@ extern AST* root;
 extern char* inp;
 extern int yyparse();
 
-Stack* scope;
-
 int main(int argc, char** argv) {
 
     if (argc - 1 && strlen(argv[1]) > 0 && (inp = argv[1]) && !yyparse()) {
         log_dbg("Parsed successfully!\n");
         ast_print(exec_start(root));
-        HTab* global = stack_pop(scope);
-        htab_destroy(global);
-        stack_destroy(scope);
         ast_destroy(root);
         exit(0);
     }
@@ -63,9 +56,6 @@ int main(int argc, char** argv) {
 #endif
 
             ast_print(exec_start(root));
-            HTab* global = stack_pop(scope);
-            htab_destroy(global);
-            stack_destroy(scope);
 
             ast_destroy(root);
         }

src/scope.c

@@ -12,12 +12,14 @@ Scope* scope_init(Scope* inherit) {
 }
 
 void scope_destroy(Scope* scope) {
+    if (!scope) return;
     htab_destroy(scope->here);
     if (scope->inherit != NULL) scope_destroy(scope->inherit);
     free(scope);
 }
 
 void scope_destroy_psv(Scope* scope) {
+    if (!scope) return;
     htab_destroy(scope->here);
     scope->inherit = NULL;
     free(scope);

test/Unity

@@ -1 +1 @@
-Subproject commit 73237c5d224169c7b4d2ec8321f9ac92e8071708
+Subproject commit cdf1d0297effc2736ee847e557b4275b4f02310b